Added Enum stubs to make method purity precise #4079
+58
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonuexe
force-pushed
the
add-enum-stub
branch
2 times, most recently
from
98a9c9b to
17b4ef2
Compare
zonuexe
commented
Jul 4, 2025
| public static function from(int|string $value): static; | ||
|
|
||
| /** | ||
| * @return ?static |
There was a problem hiding this comment.
While debugging with @nsfisis, he pointed out that this DocBlock causes the return value to be a mixed type.
Although it is redundant, in the scope of this PR it makes sense to duplicate the type declarations in the PHPDoc.
|
This pull request has been marked as ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#13201